refactor: ILPP to import references from companion modules#2199
Merged
refactor: ILPP to import references from companion modules#2199
Conversation
jeffreyrainy
approved these changes
Sep 13, 2022
Contributor
jeffreyrainy
left a comment
There was a problem hiding this comment.
Works for me, thank you.
Contributor
This was referenced Sep 19, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2192
Basically, ILPP imports type references from companion (already loaded and associated) modules instead of resolving them from
typeof(XXX)types which could be from non-release, debug/editor assemblies.Changelog
TypeLoadExceptionon WebGL on MacOS Editor and potentially other platforms.Testing and Documentation